Date: Tue, 31 Mar 2015 12:46:21 +0200 (CEST) From: Emeric POUPON <emeric.poupon@stormshield.eu> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Hans Petter Selasky <hps@selasky.org>, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Ian Lepore <ian@freebsd.org>, svn-src-all@freebsd.org, Slawa Olhovchenkov <slw@zxy.spb.ru>, svn-src-head@freebsd.org, Fabien Thomas <fabient@freebsd.org> Subject: Re: svn commit: r280759 - head/sys/netinet Message-ID: <571890548.26848580.1427798781891.JavaMail.zimbra@stormshield.eu> In-Reply-To: <20150330223836.GY64665@FreeBSD.org> References: <20150329210757.GA64665@FreeBSD.org> <551948A4.1070408@selasky.org> <5519535C.40608@selasky.org> <20150330141616.GC74532@zxy.spb.ru> <1872802434.26738716.1427729028579.JavaMail.zimbra@stormshield.eu> <20150330152707.GP64665@FreeBSD.org> <964618150.26750606.1427732445799.JavaMail.zimbra@stormshield.eu> <20150330223836.GY64665@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I tested it on a 4 core system: - I still can't see any duplicated id in my tests, so this is good. - as already discussed before, I don't see any performance impact So for me it is good! Emeric ----- Mail original ----- De: "Gleb Smirnoff" <glebius@FreeBSD.org> =C3=80: "Emeric POUPON" <emeric.poupon@stormshield.eu> Cc: "Slawa Olhovchenkov" <slw@zxy.spb.ru>, "Hans Petter Selasky" <hps@selas= ky.org>, "Adrian Chadd" <adrian@freebsd.org>, src-committers@freebsd.org, "= Ian Lepore" <ian@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebs= d.org, "Fabien Thomas" <fabient@freebsd.org> Envoy=C3=A9: Mardi 31 Mars 2015 00:38:36 Objet: Re: svn commit: r280759 - head/sys/netinet On Mon, Mar 30, 2015 at 06:20:45PM +0200, Emeric POUPON wrote: E> Yes, sure! E>=20 E> I will test it tomorrow and tell you the results. E> However, keep in mind I did not see any performance impact with the prev= ious patch. I created a patch that enables RFC6864 and per-CPU ip_id for those packets, that do not qualify for being atomic. It is here: https://reviews.freebsd.org/D2177 --=20 Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?571890548.26848580.1427798781891.JavaMail.zimbra>