Date: Mon, 12 Nov 2012 21:32:44 +0900 From: WATANABE Kazuhiro <CQG00620@nifty.ne.jp> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/173576: [patch] x11/rxvt: Wrong operators in Makefile Message-ID: <20121112123244.44D1C107CBD@mail1.asahi-net.or.jp> Resent-Message-ID: <201211121300.qACD00jr008747@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173576
>Category: ports
>Synopsis: [patch] x11/rxvt: Wrong operators in Makefile
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 12 13:00:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: WATANABE Kazuhiro
>Release: FreeBSD 9.0-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD capricorn.sign.local 9.0-RELEASE-p4 FreeBSD 9.0-RELEASE-p4 #4 r239127M: Tue Aug 7 21:51:11 JST 2012 nabe@capricorn:/FreeBSD/obj/i386/releng_9.0/FreeBSD/releng_9.0/src/sys/GENERIC i386
>Description:
The latest commit uses wrong operators in Makefile.
It loses the previous definition of CONFIGURE_ARGS.
See the patch below.
"--disable-utmp" should be combined with "--disable-wtmp".
If not, it occurs a compilation error.
>How-To-Repeat:
(With the operator's fix and without "--disable-wtmp")
# cd /usr/ports/x11/rxvt
# make BATCH=yes
(snip)
cc -DHAVE_CONFIG_H -c -DHAVE_LIBXPM -I/usr/local/include -I/usr/local/include/X11 -I. -I.. -I. -O2 -pipe -fno-strict-aliasing logging.c
logging.c:66: warning: 'struct utmp' declared inside parameter list
logging.c:66: warning: its scope is only this definition or declaration, which is probably not what you want
logging.c: In function 'rxvt_update_wtmp':
logging.c:85: error: invalid application of 'sizeof' to incomplete type 'struct utmp'
*** Error code 1
Stop in /FreeBSD/ports/x11/rxvt/work/rxvt-2.6.4/src.
*** Error code 1
Stop in /FreeBSD/ports/x11/rxvt/work/rxvt-2.6.4.
*** Error code 1
Stop in /FreeBSD/ports/x11/rxvt.
#
>Fix:
diff -urN rxvt.orig/Makefile rxvt/Makefile
--- rxvt.orig/Makefile 2012-10-28 14:56:40.000000000 +0900
+++ rxvt/Makefile 2012-11-10 23:18:11.000000000 +0900
@@ -33,7 +33,7 @@
XIM_DESC= Build with XIM support
XTERM_DESC= Build with Xterm scrollbar
-CONFIGURE_ARGS= --enable-wtmp --enable-ttygid \
+CONFIGURE_ARGS= --enable-ttygid \
--with-xpm --enable-xpm-background \
--with-xpm-includes=${LOCALBASE}/include/X11 \
--with-xpm-library=${LOCALBASE}/lib
@@ -44,9 +44,9 @@
# fails to build with new utmpx
.if ${OSVERSION} > 900007
-CONFIGURE_ARGS= --disable-utmp
+CONFIGURE_ARGS+= --disable-utmp --disable-wtmp
.else
-CONFIGURE_ARGS= --enable-utmp
+CONFIGURE_ARGS+= --enable-utmp --enable-wtmp
.endif
.if ${PORT_OPTIONS:MBIG5}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121112123244.44D1C107CBD>