Date: Thu, 16 Feb 2006 13:57:48 +0100 From: Markus Brueffer <markus@brueffer.de> To: Alexander Leidinger <Alexander@leidinger.net> Cc: freebsd-bluetooth@freebsd.org, freebsd-usb@freebsd.org Subject: Re: [Patch] Fix collection entry parsing in libusbhid Message-ID: <200602161357.54103.markus@brueffer.de> In-Reply-To: <20060216084717.yyj986z4ckow4w0w@netchild.homeip.net> References: <200602151551.27188.markus@brueffer.de> <20060216084717.yyj986z4ckow4w0w@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Am Thursday 16 February 2006 08:47 schrieb Alexander Leidinger: > Markus Brueffer <markus@brueffer.de> wrote: > > Furthermore I have removed the loop in REPORT_SAVED_COLL. If someone > > knows why > > it was there in the first place, please share your wisdom :) > > This is done in many places in the source. It's a common way of writting a > macro which is usable like a function (yes, this macro returns, so it > doesn't _work_ like a function, but this is not the point). Usually this is > used with macros which take arguments. You just can add a ';' after the use > of the macro without having to remember if you need to do it, or if your > compiler may moan because of an empty statement. > > Have a look into style(9), it also has to say something about it. Ah, I see. Thanks for the explanation. I have updated the diff to not remove the loop. Markus -- Markus Brueffer | GPG-Key: http://people.FreeBSD.org/~markus/markus.asc markus@brueffer.de | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4 markus@FreeBSD.org | FreeBSD: The Power to Serve! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD9HbS1I0Qcnj4qNQRAlckAKCdeI1StIqz0d+WbGY3Sqci21xFlwCgmKai tR9oKVuJNuh//emY4O3mW1s= =HQbF -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602161357.54103.markus>