Date: Tue, 10 Aug 2004 21:31:21 -0700 From: "George V. Neville-Neil" <gnn@neville-neil.com> To: Robert Watson <rwatson@freebsd.org> Cc: Current <freebsd-current@freebsd.org> Subject: Re: Sleeping in "rip6_output" with the following non-sleepable locks held Message-ID: <m2n012i9d2.wl@minion.local.neville-neil.com> In-Reply-To: <Pine.NEB.3.96L.1040811001359.1357I-100000@fledge.watson.org> References: <7mbrhiibby.wl@black.imgsrc.co.jp> <Pine.NEB.3.96L.1040811001359.1357I-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Wed, 11 Aug 2004 00:14:49 -0400 (EDT),
Robert Watson wrote:
>
>
> On Wed, 11 Aug 2004, Jun Kuriyama wrote:
>
> > This is today's -current on amd64 box:
>
> Hmm. There was a patch floating around for this based on my suggestion of
> converting this to an M_DONTWAIT and then handling the error case, but I
> don't seem to be able to find it in my mailbox. Do you have a copy?
>
I believe this is what you mean:
@@ -376,7 +377,12 @@
code = icmp6->icmp6_code;
}
- M_PREPEND(m, sizeof(*ip6), M_TRYWAIT);
+ M_PREPEND(m, sizeof(*ip6), M_DONTWAIT);
+ if (m == NULL) {
+ error = ENOBUFS;
+ goto bad;
+ }
+
ip6 = mtod(m, struct ip6_hdr *);
/*
Later,
George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m2n012i9d2.wl>