Date: Tue, 28 Jan 2014 06:40:01 GMT From: John Howie <john@thehowies.com> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/186006: buildworld libc build error "'MALLOC_PRODUCTION' macro redefined [-Werror]" in 10.0-RELEASE in jemalloc_jemalloc.c Message-ID: <201401280640.s0S6e1JO095326@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/186006; it has been noted by GNATS. From: John Howie <john@thehowies.com> To: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>, John Howie <john@thehowies.com> Cc: Subject: Re: misc/186006: buildworld libc build error "'MALLOC_PRODUCTION' macro redefined [-Werror]" in 10.0-RELEASE in jemalloc_jemalloc.c Date: Tue, 28 Jan 2014 06:36:16 +0000 Did some digging and found the problem. The build script for ARM has the following line: make -C $SRCROOT MALLOC_PRODUCTION=3Dyes buildworld In the file contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h the following lines exist: #define MALLOC_PRODUCTION #ifndef MALLOC_PRODUCTION #define JEMALLOC_DEBUG #endif The bug is therefor not limited to the ARM processor build of 10.0-RELEASE. Recommendation is to remove the definition of MALLOC_PRODUCTION from the header file, and document MALLOC_PRODUCTION properly (it is referenced in https://wiki.freebsd.org/DefaultDebuggingKnobs and a few other places). Regards, John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401280640.s0S6e1JO095326>