Date: Fri, 20 Jul 2007 15:12:02 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: chinsan <chinsan.tw@gmail.com> Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml Message-ID: <1184937122.13381.34.camel@pav.hide.vol.cz> In-Reply-To: <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com> References: <200707201246.l6KCkC8M062760@repoman.freebsd.org> <1184936122.13381.28.camel@pav.hide.vol.cz> <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
chinsan píše v pá 20. 07. 2007 v 21:06 +0800:
> The Original:
> @${REINPLACE_CMD} -e 's|-pthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure
> The patched:
> @${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure
>
> Since "PTHREAD_LIBS?= -pthread", so why we should replace it again?
> Therefore, it was guessed as a typo of "-lpthread" instead of "-pthread".
> Because PTHREAD_LIBS = -pthread. :)
>
> The following text is just a quote
> "If a port insists on linking -lpthread or -lc_r directly, patch it to use
> PTHREAD_LIBS variable provided by the ports framework."
People are supposed to patch s|-pthread|${PTHREAD_LIBS}| too, because
PTHREAD_LIBS are not guaranteed to be equal to -pthread forever.
--
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
What do we know about love? Love is like a pear. Pear is sweet and have
a specific shape. Try to exactly define the shape of a pear.
-- Marigold: 50 Years Of Poetry
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQBGoLSintdYP8FOsoIRAlwbAJ0e2VccruiomaJmfMqfGwdIGhaztACfWe5A
r+rDCMF1Dplinn+6hDnRzqM=
=fFKh
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1184937122.13381.34.camel>