Date: Tue, 27 Jan 2026 03:50:41 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Robert Clausecker <fuz@fuz.su> Cc: Vladimir Druzenko <vvd@freebsd.org>, Robert Clausecker <fuz@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8a6ffe8081c9 - main - devel/fnc: unbundle sqlite3 Message-ID: <aXg2Ebww-j3Baq9O@FreeBSD.org> In-Reply-To: <aXgPTrqThdPSGmzr@fuz.su> References: <6977f216.39f68.198cc9be@gitrepo.freebsd.org> <dec7ca0a-53fc-40f5-8e03-109702706b5e@freebsd.org> <aXgPTrqThdPSGmzr@fuz.su>
index | next in thread | previous in thread | raw e-mail
On Tue, Jan 27, 2026 at 02:05:18AM +0100, Robert Clausecker wrote:
> Am Tue, Jan 27, 2026 at 02:51:09AM +0300 schrieb Vladimir Druzenko:
> > 27.01.2026 02:00, Robert Clausecker пишет:
> > > The branch main has been updated by fuz:
> > > devel/fnc: unbundle sqlite3
> > > @@ -21,6 +24,7 @@ PLIST_FILES= bin/fnc \
> > > # For patch application
> > > post-extract:
> > > + ${RM} ${WRKSRC}/lib/sqlite3.*
> > > ${REINPLACE_CMD} -e '/^VERSION/s/${DISTVERSION}$$/%%VERSION%%/' \
> > > ${WRKSRC}/fnc.bld.mk
> >
> > EXTRACT_AFTER_ARGS= --exclude ${DISTNAME}/lib/sqlite3.* \
> > --no-same-owner --no-same-permissions
>
> I prefer to remove the files after the fact, as it's easier than
> remembering the special features of tar.
+1. This EXTRACT_AFTER_ARGS approach gets overly verbose and ugly if one
needs to remove more than one directory, esp. for USE_GITHUB cases due to
${GH_PROJECT_DEFAULT}-${GH_TAGNAME_EXTRACT}.
Generalizing the whole thing as part of Mk/b.p.m and hiding this complexity
behind some knob in a spirit of SHEBANG_REGEX would probably make it less
distasteful, but until then calling ${RM} looks more readable to me than
EXTRACT_AFTER_ARGS incantation.
./danfe
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aXg2Ebww-j3Baq9O>