Date: Thu, 18 Dec 1997 18:47:06 -0700 From: Nate Williams <nate@mt.sri.com> To: hosokawa@ntc.keio.ac.jp (HOSOKAWA Tatsumi) Cc: faber@ISI.EDU, nate@mt.sri.com, ambrisko@whistle.com, freebsd-mobile@FreeBSD.ORG Subject: Re: Message-ID: <199712190147.SAA18752@mt.sri.com> In-Reply-To: <199712190142.KAA15429@afs.ntc.mita.keio.ac.jp> References: <199712182355.PAA24716@tnt.isi.edu> <199712190142.KAA15429@afs.ntc.mita.keio.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> Well, it doesn't *break* anything, but it's icky. :-) I just have a
> >> preference for configurable systems. I agree however that making a
> >> parameter configurable that no one con configure isn't worth much
> >> (other than as incentive to change the unconfigurable stuff).
>
> I think it'll cause problems on machines that have more than two
> CardBus bridges, or machines that have both ISA PC-card controller and
> CardBus bridges.
Good call!
> I think it'll be te better way:
>
> if (the legacy 16bit ioadder is left uninitialized, or initialized
> to odd value) {
> set it to 0x3e0 + (unit number * 2);
> }
>
> or
>
> if (the legacy 16bit ioadder is left uninitialized) {
> set it to 0x3e0 + (unit number * 2);
> }
>
> sp->index = legacy 16bit ioaddr;
Agreed. Thanks for the feedback!
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712190147.SAA18752>