Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 28 May 2009 16:08:33 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r192982 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern
Message-ID:  <200905281608.n4SG8XHP042841@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: kib
Date: Thu May 28 16:08:33 2009
New Revision: 192982
URL: http://svn.freebsd.org/changeset/base/192982

Log:
  MFC r191895:
  Eliminate the loop and the call to pause(9) in vfs_vget_ino().
  
  Tested by:	Mykola Dzham <i levsha org ua>

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/kern/vfs_vnops.c

Modified: stable/7/sys/kern/vfs_vnops.c
==============================================================================
--- stable/7/sys/kern/vfs_vnops.c	Thu May 28 16:05:22 2009	(r192981)
+++ stable/7/sys/kern/vfs_vnops.c	Thu May 28 16:08:33 2009	(r192982)
@@ -1226,26 +1226,30 @@ int
 vn_vget_ino(struct vnode *vp, ino_t ino, int lkflags, struct vnode **rvp)
 {
 	struct mount *mp;
+	struct thread *td;
 	int ltype, error;
 
 	mp = vp->v_mount;
-	ltype = VOP_ISLOCKED(vp, curthread);
+	td = curthread;
+	ltype = VOP_ISLOCKED(vp, td);
 	KASSERT(ltype == LK_EXCLUSIVE || ltype == LK_SHARED,
 	    ("vn_vget_ino: vp not locked"));
-	for (;;) {
-		error = vfs_busy(mp, LK_NOWAIT, NULL, curthread);
-		if (error == 0)
-			break;
-		VOP_UNLOCK(vp, 0, curthread);
-		pause("vn_vget", 1);
-		vn_lock(vp, ltype | LK_RETRY, curthread);
-		if (vp->v_iflag & VI_DOOMED)
+	error = vfs_busy(mp, LK_NOWAIT, NULL, td);
+	if (error != 0) {
+		VOP_UNLOCK(vp, 0, td);
+		error = vfs_busy(mp, 0, NULL, td);
+		vn_lock(vp, ltype | LK_RETRY, td);
+		if (error != 0)
+			return (ENOENT);
+		if (vp->v_iflag & VI_DOOMED) {
+			vfs_unbusy(mp, td);
 			return (ENOENT);
+		}
 	}
-	VOP_UNLOCK(vp, 0, curthread);
+	VOP_UNLOCK(vp, 0, td);
 	error = VFS_VGET(mp, ino, lkflags, rvp);
-	vfs_unbusy(mp, curthread);
-	vn_lock(vp, ltype | LK_RETRY, curthread);
+	vfs_unbusy(mp, td);
+	vn_lock(vp, ltype | LK_RETRY, td);
 	if (vp->v_iflag & VI_DOOMED) {
 		if (error == 0)
 			vput(*rvp);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905281608.n4SG8XHP042841>