Date: Fri, 20 Mar 2020 16:24:06 +0000 (UTC) From: Mark Johnston <markj@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r359172 - head/contrib/elftoolchain/libdwarf Message-ID: <202003201624.02KGO6pk077990@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: markj Date: Fri Mar 20 16:24:06 2020 New Revision: 359172 URL: https://svnweb.freebsd.org/changeset/base/359172 Log: libdwarf: Make an out-pointer assignment unconditional. There is no reason for diep to ever be NULL, since in that case we would simply be leaking memory. CID: 1418801 MFC after: 1 week Sponsored by: The FreeBSD Foundation Modified: head/contrib/elftoolchain/libdwarf/libdwarf_die.c Modified: head/contrib/elftoolchain/libdwarf/libdwarf_die.c ============================================================================== --- head/contrib/elftoolchain/libdwarf/libdwarf_die.c Fri Mar 20 16:18:54 2020 (r359171) +++ head/contrib/elftoolchain/libdwarf/libdwarf_die.c Fri Mar 20 16:24:06 2020 (r359172) @@ -70,8 +70,7 @@ _dwarf_die_add(Dwarf_CU cu, uint64_t offset, uint64_t die->die_cu = cu; die->die_dbg = cu->cu_dbg; - if (diep != NULL) - *diep = die; + *diep = die; return (DW_DLE_NONE); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003201624.02KGO6pk077990>