Date: Mon, 27 May 2019 16:40:56 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: rgrimes@freebsd.org Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r232071 - head/sys/vm Message-ID: <20190527164056.GA17917@FreeBSD.org> In-Reply-To: <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net> References: <20190527112155.GZ2748@kib.kiev.ua> <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 27, 2019 at 07:21:24AM -0700, Rodney W. Grimes wrote:
> I wish to assert again that all changes based on static
> analysis tools require a formal code review by at minimum:
> a) An expert in static analysis tools or a group of people
> selected who we consider language experts.
> b) An area expert from the area that is being affected
>
> We as a project look bad by not having this minimal
> set of code reviews in place for things that are coming
> from a source that is frought with introducing bad
> change.
Perhaps I should've just uploaded the log to let anyone interested
have a look themselves. I've been only checking the kernel so far,
but plan to cover userland as well later.
freefall:/home/danfe/pvs-studio-2019-05-27.log.xz
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190527164056.GA17917>