Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 24 Jan 2018 20:12:01 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r328357 - head/sys/dev/cxgbe/crypto
Message-ID:  <201801242012.w0OKC1lA034226@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jhb
Date: Wed Jan 24 20:12:00 2018
New Revision: 328357
URL: https://svnweb.freebsd.org/changeset/base/328357

Log:
  Fail crypto requests when the resulting work request is too large.
  
  Most crypto requests will not trigger this condition, but a request
  with a highly-fragmented data buffer (and a resulting "large" S/G
  list) could trigger it.
  
  Sponsored by:	Chelsio Communications

Modified:
  head/sys/dev/cxgbe/crypto/t4_crypto.c

Modified: head/sys/dev/cxgbe/crypto/t4_crypto.c
==============================================================================
--- head/sys/dev/cxgbe/crypto/t4_crypto.c	Wed Jan 24 20:11:00 2018	(r328356)
+++ head/sys/dev/cxgbe/crypto/t4_crypto.c	Wed Jan 24 20:12:00 2018	(r328357)
@@ -470,6 +470,8 @@ ccr_hmac(struct ccr_softc *sc, uint32_t sid, struct cc
 	}
 
 	wr_len = roundup2(transhdr_len, 16) + roundup2(imm_len, 16) + sgl_len;
+	if (wr_len > SGE_MAX_WR_LEN)
+		return (EFBIG);
 	wr = alloc_wrqe(wr_len, sc->txq);
 	if (wr == NULL) {
 		sc->stats_wr_nomem++;
@@ -626,6 +628,8 @@ ccr_blkcipher(struct ccr_softc *sc, uint32_t sid, stru
 
 	wr_len = roundup2(transhdr_len, 16) + s->blkcipher.iv_len +
 	    roundup2(imm_len, 16) + sgl_len;
+	if (wr_len > SGE_MAX_WR_LEN)
+		return (EFBIG);
 	wr = alloc_wrqe(wr_len, sc->txq);
 	if (wr == NULL) {
 		sc->stats_wr_nomem++;
@@ -947,6 +951,8 @@ ccr_authenc(struct ccr_softc *sc, uint32_t sid, struct
 
 	wr_len = roundup2(transhdr_len, 16) + s->blkcipher.iv_len +
 	    roundup2(imm_len, 16) + sgl_len;
+	if (wr_len > SGE_MAX_WR_LEN)
+		return (EFBIG);
 	wr = alloc_wrqe(wr_len, sc->txq);
 	if (wr == NULL) {
 		sc->stats_wr_nomem++;
@@ -1256,6 +1262,8 @@ ccr_gcm(struct ccr_softc *sc, uint32_t sid, struct ccr
 
 	wr_len = roundup2(transhdr_len, 16) + iv_len + roundup2(imm_len, 16) +
 	    sgl_len;
+	if (wr_len > SGE_MAX_WR_LEN)
+		return (EFBIG);
 	wr = alloc_wrqe(wr_len, sc->txq);
 	if (wr == NULL) {
 		sc->stats_wr_nomem++;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801242012.w0OKC1lA034226>