Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Jan 2010 03:49:42 GMT
From:      Rob Farmer <rfarmer@predatorlabs.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/142706: [PATCH] ftp/cftp Fix local buffer overflow, update WWW, take maintainership
Message-ID:  <201001110349.o0B3ngpt014769@www.freebsd.org>
Resent-Message-ID: <201001110350.o0B3oA1E012000@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         142706
>Category:       ports
>Synopsis:       [PATCH] ftp/cftp Fix local buffer overflow, update WWW, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 11 03:50:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Rob Farmer
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD peridot.predatorlabs.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r201657: Wed Jan 6 09:49:06 PST 2010 robert@peridot.predatorlabs.net:/usr/obj/usr/src/sys/PERIDOT i386
>Description:
* Fix local buffer overflow (obtained from NetBSD)
* Update WWW
* Take maintainership
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN cftp.old/Makefile cftp/Makefile
--- cftp.old/Makefile	2010-01-09 23:28:02.000000000 -0800
+++ cftp/Makefile	2010-01-09 23:38:00.000000000 -0800
@@ -7,12 +7,12 @@
 
 PORTNAME=	cftp
 PORTVERSION=	0.12
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	ftp ipv6
 MASTER_SITES=	ftp://ftp.giga.or.at/pub/nih/cftp/ \
 		ftp://sunsite.univie.ac.at/pub/nih/cftp/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	rfarmer@predatorlabs.net
 COMMENT=	Comfortable FTP, a full screen ftp client
 
 GNU_CONFIGURE=	yes
diff -ruN cftp.old/files/patch-readrc.c cftp/files/patch-readrc.c
--- cftp.old/files/patch-readrc.c	1969-12-31 16:00:00.000000000 -0800
+++ cftp/files/patch-readrc.c	2010-01-09 23:33:38.000000000 -0800
@@ -0,0 +1,11 @@
+--- readrc.c.orig	2010-01-09 23:30:28.000000000 -0800
++++ readrc.c	2010-01-09 23:31:10.000000000 -0800
+@@ -46,7 +46,7 @@
+     char b[8192], *p, *tok, *q, *home;
+     char *user, *pass, *host, *port, *wdir;
+ 
+-    if ((home=getenv("HOME")) == NULL)
++    if ((home=getenv("HOME")) == NULL || strlen(home) > sizeof(b)-9)
+ 	home = "";
+     sprintf(b, "%s/.cftprc", home);
+     
diff -ruN cftp.old/pkg-descr cftp/pkg-descr
--- cftp.old/pkg-descr	2010-01-09 23:28:02.000000000 -0800
+++ cftp/pkg-descr	2010-01-09 23:36:03.000000000 -0800
@@ -4,4 +4,5 @@
 fullscreen representation of the remote directory so you 
 can easily choose what to get or where to go.
 
-WWW: http://ftp.giga.or.at/pub/nih/cftp/
+WWW: http://nih.at/cftp/
+


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001110349.o0B3ngpt014769>