Date: Wed, 6 Dec 2017 09:38:47 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: cem@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <20171206083847.f4t5wdtf6toaua63@ivaldir.net> In-Reply-To: <89b00017-aa92-66ca-5a28-47f0eb8f399b@freebsd.org> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com> <89b00017-aa92-66ca-5a28-47f0eb8f399b@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--26zso3mqgppcsewa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 05, 2017 at 08:42:11PM -0500, Allan Jude wrote: > On 2017-12-05 20:17, Conrad Meyer wrote: > > Ping. Please revert this change. If you want zstd to behave this > > way, pursue it upstream first. > >=20 > > Thanks, > > Conrad > >=20 > > On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer <cem@freebsd.org> wrote: > >> Please revert this change. > >> > >> First, it introduces the POLA-violating behavior that zstdcat deletes > >> its source files. This is not how zcat/bzcat behaves. > >> > >> Second, it introduces a needless behavioral difference between FreeBSD > >> zstd and the rest of the world's zstd. The zstd documentation we ship > >> continues to claim that zstd preserves source files by default, yet > >> this change makes that documentation exactly backwards. While we can > >> change FreeBSD's documentation to accommodate the change, we can't > >> change Google results. > >> > >> Thanks, > >> Conrad > >> > >> On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin <bapt@freebsd.org>= wrote: > >>> Author: bapt > >>> Date: Sat Apr 15 20:15:44 2017 > >>> New Revision: 316980 > >>> URL: https://svnweb.freebsd.org/changeset/base/316980 > >>> > >>> Log: > >>> Change some default to make zstd a dropin replacement for gzip,bzip= etc > >>> in most cases > >>> > >>> Changes ares: > >>> - quiet by default > >>> - remove the source files one compression completion by default > >>> > >>> Modified: > >>> head/contrib/zstd/programs/fileio.c > >>> head/contrib/zstd/programs/zstdcli.c > >>> > >>> Modified: head/contrib/zstd/programs/fileio.c > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 = (r316979) > >>> +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 = (r316980) > >>> @@ -138,7 +138,7 @@ static U32 g_dictIDFlag =3D 1; > >>> void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag =3D dictI= DFlag; } > >>> static U32 g_checksumFlag =3D 1; > >>> void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag =3D= checksumFlag; } > >>> -static U32 g_removeSrcFile =3D 0; > >>> +static U32 g_removeSrcFile =3D 1; > >>> void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile =3D (flag= >0); } > >>> static U32 g_memLimit =3D 0; > >>> void FIO_setMemLimit(unsigned memLimit) { g_memLimit =3D memLimit; } > >>> > >>> Modified: head/contrib/zstd/programs/zstdcli.c > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 2= 017 (r316979) > >>> +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 2= 017 (r316980) > >>> @@ -61,7 +61,7 @@ > >>> #define MB *(1 <<20) > >>> #define GB *(1U<<30) > >>> > >>> -#define DEFAULT_DISPLAY_LEVEL 2 > >>> +#define DEFAULT_DISPLAY_LEVEL 1 > >>> > >>> static const char* g_defaultDictName =3D "dictionary"; > >>> static const unsigned g_defaultMaxDictSize =3D 110 KB; > >>> > >=20 >=20 > Upstream recommends we create an additional hardlink, called 'zz' (like > xz but zstd), to do such compatibility, and keep 'zstd' the same as zstd > on every other distro. >=20 Actually I would prefer not to do it and simply adapt newsyslog to be more flexible. it is the only consumer of the zstd command. Bapt --26zso3mqgppcsewa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlonrJcACgkQY4mL3PG3 PlralQ/9H7S2z1dWwe7Z7EmcL4IjbpmOIYs2gx70GsdVzQWwtayDQomFNUNRCQM0 r+VVuyDAiV+Co38C/+ItkzxG5H++MCDzBQDDGdk4k/M5si9PyZLP0mFs6QVnlCwu UGtpV1UpHN+djpZc7HfIkiReJ6Y/2paXg2oVeD+RmHu7bcZgqI2vz7WxVP+J03cS 84xfNkhvfJb02NYqARE8fBHBITXkk5Y+gQWNtQkndQHtNnpWVJL0ZTdW6kyG2enw LuLhdiQLHPCN+q1CxtidsgEQgphth8khUPyfQLyxctWefuhL8JclaR4GD1iOdbIl BpZ09o9hH6gsxTWQ1urqChGff1XdcHxa2I8cI+32XILW/XiW4u9A2GR467DEjyBF P2PdSOLOG29Ylq45/E1z/moKFs4XX/2QbmpvtK12+wruvOsgf6i+5aQhtMzlBaZS ofJySbcM2O8bQdJ1/H0KikS0fBmKy6I6905LCvGYZKyy9mrUbfCMQ+zKtAHh8HPk pkYi4chLEbjcyjzkmH35JesY0cgFfxsdjyxvHZHo6ioV81nTO2VkMUe1ItE12qNx f8+2m3bIhGntZd2ejTWa/hIVlzvVzgPQvn9tWHSxu3+FFXpGDxVvPmGoz3PaYamk I1+M4ZBO2aqlMRbJF369cB5FlIcUJ0FbnGimIEH+VkNs6M1LzBI= =H5xT -----END PGP SIGNATURE----- --26zso3mqgppcsewa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171206083847.f4t5wdtf6toaua63>