Date: Fri, 28 Jun 2013 11:09:23 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r252101 - head/release Message-ID: <20130628150923.GA1687@glenbarber.us> In-Reply-To: <1D76B2CE-575C-4456-BC3A-7249D030970A@gmail.com> References: <201306222212.r5MMCO8t091190@svn.freebsd.org> <1397DF51-1DCC-47BC-931A-5D26C94A0811@gmail.com> <20130622225106.GK1888@glenbarber.us> <1D76B2CE-575C-4456-BC3A-7249D030970A@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--tKW2IUtsqtDRztdT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 27, 2013 at 12:13:51PM -0700, Garrett Cooper wrote: > On Jun 22, 2013, at 3:51 PM, Glen Barber wrote: >=20 > > On Sat, Jun 22, 2013 at 03:39:41PM -0700, Garrett Cooper wrote: > >> On Jun 22, 2013, at 3:12 PM, Glen Barber wrote: > >>=20 > >>> Author: gjb > >>> Date: Sat Jun 22 22:12:24 2013 > >>> New Revision: 252101 > >>> URL: http://svnweb.freebsd.org/changeset/base/252101 > >>>=20 > >>> Log: > >>> If MAKE_CONF and/or SRC_CONF are set and not character devices, > >>> copy to chroot to use with release build. > >>>=20 > >>> Submitted by: Garrett Cooper (original version) > >>> Approved by: kib (mentor) > >>> MFC after: 1 week > >>>=20 > >>> Modified: > >>> head/release/release.sh > >>=20 > >> Technically copying /dev/null to a file creates a 0 byte file. > >> That's why I used cp in the patch I submitted over email. > >> Thanks! > >=20 > > Right. But did you read the script? > >=20 > > Both __MAKE_CONF and SRCCONF are set to the path of the local files. >=20 > Oh, interesting=E2=80=A6 I see what you did there instead of what > I proposed; I copied __MAKE_CONF to /etc/make.conf and SRCCONF to > /etc/src.conf for symmetry with the base system, but your method > works more than mine did (I forgot that you were passing those vars > in the chroot environment). Should the files be installed to /etc/ > in the system default locations ? My initial reaction is "no." Those who are using __MAKE_CONF and SRCCONF in such an environment know why they are doing so. So, in my opinion, it is up to them to modify the end-release as needed. Since __MAKE_CONF and SRCCONF are pointing to /dev/null in release builds, I do not see this as necessary. Moreso, I do not want to introduce a level of confusion where /etc/make.conf and/or /etc/src.conf are modified within the release, or worse, in an altogether different location. There is too much complexity here. Glen --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJRzacjAAoJEFJPDDeguUajLKMH/RjizWSVHOvpcFiMafvGf/oj FFScASbWoTWeuwk7zc/CIO27tIUi95qcfuKy5zu7FsWk5SLk6iRTEXQv69+2cwWO jD4NFA54u6Xj4KZijwR4Tv0zxzZ/pkCdjhW5k5yejYf3xOqLrsasqmGUOHOtRtLu C8xx8ggHPCO7RhfZFWCBarM5q13RlS9bXaUPeXrHWmXIVmB6Poft5JczJ1/Vbf08 dLUOkn8e2rsHi4piMKFzUvlw4WXzNV0tbU1HDkdPQpK65I/TPxg/lIyhZb2n3ZVr s3acsE9+vvmu6AafVD9cIvvEJ39vSBZzrYrLrwDRRxc2YgGMlgev8KzL/IQedNg= =gII6 -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130628150923.GA1687>