Date: Fri, 29 Jun 2012 10:09:08 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: obrien@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... Message-ID: <1340989748.73663.YahooMailClassic@web113504.mail.gq1.yahoo.com> In-Reply-To: <20120629152109.GA70522@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi David;=0A=0A--- Ven 29/6/12, David O'Brien <obrien@FreeBSD.org> ha scrit= to:=0A...=0A> ...=0A> > +/*=0A> > + * Copyright (c) 2011, Joyent, Inc. All = rights=0A> reserved.=0A> > + */=0A> =0A> Pedro,=0A> It looks like you simpl= y 'svn add'ed this file, rather than=0A> importing it into '^/vendor/openso= laris/dist'.=A0 =0A> Please correct me if I am wrong.=0A> =0A=0AYou are abs= olutely right. However I am not sure we should=0Abring Illumos enhancements= under the opensolaris vendor=0Abranch. The reason is that this files are C= DDL'd but are=0Athere was no property assignment done to the OpenSolaris=0A= copyright owner. [1]=0A=0AIf somehow Oracle decides to relicense Dtrace or = ZFS we=0Astill must keep these changes isolated from the code=0Aprovided in= the vendor branch.=0A=0A=0A> We've become rather sloppy in the past 1-2 ye= ars in our=0A> handling of 3rd-party externally developed code.=A0 Somethin= g=0A> we need to return to our older ways good ways of handling.=0A> =0A=0A= Yes, that is true.=0A=0AI think we have to decide if we are going to consid= er=0AIllumos a vendor on it's own. For ZFS it would seem=0Athe right thing = to do, for Dtrace I am not sure: at=0Aleast I am not considering bringing a= ny other feature=0Aat this time.=0A=0A=0AThank you for the links on Code Pr= ovenance Review.=0A=0A> =0A> Please correct this by properly importing the = sources, 'svn=0A> delete'ing the files you 'svn add'ed, and do an 'svn copy= '=0A> of the new files.=0A>=0A=0AI think the discussion is indeed important= enough to=0Asuspend the MFC I was planning and if desired I can=0Aalso rev= ert the commit.=0A=0APedro.=0A=0A=0A[1] http://smartos.org/2011/12/15/fork-= yeah-the-rise-and-development-of-illumos-2/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340989748.73663.YahooMailClassic>