Date: Fri, 14 Jan 2022 23:41:22 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: dev-commits-src-all@FreeBSD.org, Daniel Ebdrup Jensen <debdrup@FreeBSD.org>, dev-commits-src-main@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces Message-ID: <493738071.2419.1642200082113@localhost> In-Reply-To: <202201142044.20EKirZj000512@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Van: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> Datum: 14 januari 2022 21:45 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Onderwerp: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces > > > The branch main has been updated by debdrup (doc committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=9f0b56872c1fb790f67ee45a56ceeeed5d17ddea > > commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea > Author: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > AuthorDate: 2022-01-14 20:32:06 +0000 > Commit: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > CommitDate: 2022-01-14 20:44:13 +0000 > > carp(4): Make regex additionally match on VLAN interfaces > > This tiny change to the example makes devd capable of reacting to carp > status change events on VLAN interfaces. > > Reported by: Thomas Steen Rasmussen (tykling) <thomas at gibfest.dk> > --- > share/man/man4/carp.4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4 > index 8d54d56afa03..2785b97e76ac 100644 > --- a/share/man/man4/carp.4 > +++ b/share/man/man4/carp.4 > @@ -290,7 +290,7 @@ status change events can be set up by using the following devd.conf rule: > .Bd -literal -offset indent > notify 0 { > match "system" "CARP"; > - match "subsystem" "[0-9]+@[0-9a-z]+"; > + match "subsystem" "[0-9]+@[0-9a-z.]+"; > match "type" "(MASTER|BACKUP)"; > action "/root/carpcontrol.sh $subsystem $type"; > }; > > > > > Hi, I don’t think you need to escape a dot inside a character class. But maybe this regex engine does need it. Nice change about the vlan though. Regards, Ronald [-- Attachment #2 --] <html><head></head><body><br /><p><small><strong>Van:</strong> Daniel Ebdrup Jensen <debdrup@FreeBSD.org><br /><strong>Datum:</strong> 14 januari 2022 21:45<br /><strong>Aan:</strong> src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org<br /><strong>Onderwerp:</strong> git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces<br /></small></p><blockquote style="margin-left: 5px; border-left: 3px solid #ccc; margin-right: 0px; padding-left: 5px;"><div class="MessageRFC822Viewer do_not_remove" id="P"><!-- P --> <!-- processMimeMessage --><div class="TextPlainViewer do_not_remove" id="P.P"><!-- P.P -->The branch main has been updated by debdrup (doc committer):<br /> <br /> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=9f0b56872c1fb790f67ee45a56ceeeed5d17ddea">https://cgit.FreeBSD.org/src/commit/?id=9f0b56872c1fb790f67ee45a56ceeeed5d17ddea</a><br /> <br /> commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea<br /> Author: Daniel Ebdrup Jensen <debdrup@FreeBSD.org><br /> AuthorDate: 2022-01-14 20:32:06 +0000<br /> Commit: Daniel Ebdrup Jensen <debdrup@FreeBSD.org><br /> CommitDate: 2022-01-14 20:44:13 +0000<br /> <br /> carp(4): Make regex additionally match on VLAN interfaces<br /> <br /> This tiny change to the example makes devd capable of reacting to carp<br /> status change events on VLAN interfaces.<br /> <br /> Reported by: Thomas Steen Rasmussen (tykling) <thomas at gibfest.dk><br /> ---<br /> share/man/man4/carp.4 | 2 +-<br /> 1 file changed, 1 insertion(+), 1 deletion(-)<br /> <br /> diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4<br /> index 8d54d56afa03..2785b97e76ac 100644<br /> --- a/share/man/man4/carp.4<br /> +++ b/share/man/man4/carp.4<br /> @@ -290,7 +290,7 @@ status change events can be set up by using the following devd.conf rule:<br /> .Bd -literal -offset indent<br /> notify 0 {<br /> match "system" "CARP";<br /> - match "subsystem" "[0-9]+@[0-9a-z]+";<br /> + match "subsystem" "[0-9]+@[0-9a-z.]+";<br /> match "type" "(MASTER|BACKUP)";<br /> action "/root/carpcontrol.sh $subsystem $type";<br /> };<br /> <br /> </div><!-- TextPlainViewer --> <hr /> </div><!-- MessageRFC822Viewer --> </blockquote><br /><br />Hi,<div><br />I don’t think you need to escape a dot inside a character class.<div>But maybe this regex engine does need it. <br /><div><br /></div><div>Nice change about the vlan though. </div><div><br /></div><div>Regards,</div><div>Ronald<br /><br /></div></div></div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?493738071.2419.1642200082113>