Date: Wed, 2 Jun 2010 19:01:36 GMT From: CyberLeo <cyberleo@cyberleo.net> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/147337: agp_nvidia device_printf missing newline Message-ID: <201006021901.o52J1aJA004020@www.freebsd.org> Resent-Message-ID: <201006021910.o52JA2Sk030909@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 147337 >Category: kern >Synopsis: agp_nvidia device_printf missing newline >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 02 19:10:02 UTC 2010 >Closed-Date: >Last-Modified: >Originator: CyberLeo >Release: 8.1-BETA1 >Organization: CyberLeo.Net >Environment: >Description: A device_printf call in agp_nvidia.c is missing a terminating newline in its format string. >How-To-Repeat: >Fix: Attached patch Patch attached with submission follows: --- sys/dev/agp/agp_nvidia.c 2010-03-07 05:40:17.000000000 -0600 +++ sys/dev/agp/agp_nvidia.c 2010-03-07 05:40:55.000000000 -0600 @@ -282,7 +282,7 @@ case 14: return (64 * 1024 * 1024); break; case 15: return (32 * 1024 * 1024); break; default: - device_printf(dev, "Invalid aperture setting 0x%x", + device_printf(dev, "Invalid aperture setting 0x%x\n", pci_read_config(dev, AGP_NVIDIA_0_APSIZE, 1)); return 0; } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006021901.o52J1aJA004020>