Date: Wed, 5 Aug 2015 16:25:34 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Jung-uk Kim <jkim@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286293 - head/sys/x86/include Message-ID: <20150805162146.H1434@besplex.bde.org> In-Reply-To: <201508041859.t74IxtCh047275@repo.freebsd.org> References: <201508041859.t74IxtCh047275@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Aug 2015, Jung-uk Kim wrote:
> Log:
> Fix style(9) bugs.
Thanks.
> Modified:
> head/sys/x86/include/_types.h
>
> Modified: head/sys/x86/include/_types.h
> ==============================================================================
> --- head/sys/x86/include/_types.h Tue Aug 4 17:47:11 2015 (r286292)
> +++ head/sys/x86/include/_types.h Tue Aug 4 18:59:54 2015 (r286293)
> @@ -154,12 +154,11 @@ typedef int ___wchar_t;
> typedef __builtin_va_list __va_list; /* internally known to gcc */
> #else
> #ifdef __LP64__
> -typedef struct {
> - unsigned int __gpo;
> - unsigned int __fpo;
> - void *__oaa;
> - void *__rsa;
> -} __va_list;
> +struct __s_va_list {
> + __uint32_t pad1[2]; /* gp_offset, fp_offset */
> + __uint64_t pad2[2]; /* overflow_arg_area, reg_save_area */
> +};
Er, the struct members need at least 1 underscore, since pad* is in the
application namespace and this is a very public file.
> +typedef struct __s_va_list __va_list;
I said to use #define, but now prefer this since it is better for debuggers
and all the nearby __va_list's are typedefs.
This typedef should be followed by a tab like all the nearby ones.
> #else
> typedef char * __va_list;
> #endif
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150805162146.H1434>