Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Feb 2014 14:35:19 +0000 (UTC)
From:      Christian Brueffer <brueffer@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r261980 - head/sys/i386/xbox
Message-ID:  <201402161435.s1GEZJuA069148@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brueffer
Date: Sun Feb 16 14:35:19 2014
New Revision: 261980
URL: http://svnweb.freebsd.org/changeset/base/261980

Log:
  Remove an nve(4)-specific workaround from the xbox port.  nfe(4) doesn't
  need it.
  
  Reviewed by:	ed

Modified:
  head/sys/i386/xbox/xbox.c

Modified: head/sys/i386/xbox/xbox.c
==============================================================================
--- head/sys/i386/xbox/xbox.c	Sun Feb 16 13:42:49 2014	(r261979)
+++ head/sys/i386/xbox/xbox.c	Sun Feb 16 14:35:19 2014	(r261980)
@@ -59,27 +59,6 @@ xbox_init(void)
 	/* register our poweroff function */
 	EVENTHANDLER_REGISTER (shutdown_final, xbox_poweroff, NULL,
 	                       SHUTDOWN_PRI_LAST);
-
-	/*
-	 * Some XBOX loaders, such as Cromwell, have a flaw which cause the
-	 * nve(4) driver to fail attaching to the NIC.
-	 *
-	 * This is because they leave the NIC running; this will cause the
-	 * Nvidia driver to fail as the NIC does not return any sensible
-	 * values and thus fails attaching (using an error 0x5, this means
-	 * it cannot find a valid PHY)
-	 *
-	 * We bluntly tell the NIC to stop whatever it's doing; this makes
-	 * nve(4) attach correctly. As the NIC always resides at
-	 * 0xfef00000-0xfef003ff on an XBOX, we simply hardcode this address.
-	 */
-	ptr = pmap_mapdev (0xfef00000, 0x400);
-	*(uint32_t*)(ptr + 0x188) = 0; /* clear adapter control field */
-	pmap_unmapdev ((vm_offset_t)ptr, 0x400);
 }
 
-/*
- * This must be called before the drivers, as the if_nve(4) driver will fail
- * if we do not do this in advance.
- */
 SYSINIT(xbox, SI_SUB_DRIVERS, SI_ORDER_FIRST, xbox_init, NULL);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402161435.s1GEZJuA069148>