Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Jul 2023 23:19:53 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 59dc489a7e03 - main - mpr: Fix minor 'typos' comment
Message-ID:  <202307202319.36KNJriX085667@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=59dc489a7e034674c3f52c56c95851bf31dc790b

commit 59dc489a7e034674c3f52c56c95851bf31dc790b
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-07-20 23:16:04 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-07-20 23:18:28 +0000

    mpr: Fix minor 'typos' comment
    
    moving -> removing (we're removing the device)
    CAM_REQ_CMO_ERROR -> CAM_REQ_ERR (the former isn't a thing)
    
    Sponsored by:           Netflix
---
 sys/dev/mpr/mpr_sas.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/mpr/mpr_sas.c b/sys/dev/mpr/mpr_sas.c
index dd630d212b7f..06dbed57dbac 100644
--- a/sys/dev/mpr/mpr_sas.c
+++ b/sys/dev/mpr/mpr_sas.c
@@ -2767,13 +2767,13 @@ mprsas_scsiio_complete(struct mpr_softc *sc, struct mpr_command *cm)
 		 * count by returning CAM_REQUEUE_REQ.  Unfortunately, if
 		 * we hit a persistent drive problem that returns one of
 		 * these error codes, we would retry indefinitely.  So,
-		 * return CAM_REQ_CMP_ERROR so that we decrement the retry
+		 * return CAM_REQ_CMP_ERR so that we decrement the retry
 		 * count and avoid infinite retries.  We're taking the
 		 * potential risk of flagging false failures in the event
 		 * of a topology-related error (e.g. a SAS expander problem
 		 * causes a command addressed to a drive to fail), but
 		 * avoiding getting into an infinite retry loop. However,
-		 * if we get them while were moving a device, we should
+		 * if we get them while were removing a device, we should
 		 * fail the request as 'not there' because the device
 		 * is effectively gone.
 		 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307202319.36KNJriX085667>