Date: Wed, 18 Feb 2015 19:24:04 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: svn commit: r278889 - head/lib/libc/include Message-ID: <54E53B34.5070605@FreeBSD.org> In-Reply-To: <20150219113226.K2984@besplex.bde.org> References: <201502170854.t1H8s4TL085174@svn.freebsd.org> <54E52019.8080009@FreeBSD.org> <20150219113226.K2984@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2/18/2015 6:58 PM, Bruce Evans wrote: > On Wed, 18 Feb 2015, Bryan Drewery wrote: > >> On 2/17/2015 2:54 AM, Konstantin Belousov wrote: >>> ... >>> Log: >>> Restore the extern qualifier on __cleanup. >>> ... >>> Modified: head/lib/libc/include/libc_private.h >>> ============================================================================== >>> >>> --- head/lib/libc/include/libc_private.h Tue Feb 17 08:50:26 >>> 2015 (r278888) >>> +++ head/lib/libc/include/libc_private.h Tue Feb 17 08:54:03 >>> 2015 (r278889) >>> @@ -271,7 +271,7 @@ void _malloc_first_thread(void); >>> /* >>> * Function to clean up streams, called from abort() and exit(). >>> */ >>> -void (*__cleanup)(void) __hidden; >>> +extern void (*__cleanup)(void) __hidden; >>> >>> /* >>> * Get kern.osreldate to detect ABI revisions. Explicitly >>> >> >> Is this a NOP? > > No, since this is a data declaration. It would be a style bug on a > prototype. Ah, of course. I missed the *, despite the (). -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU5Ts0AAoJEDXXcbtuRpfP3w8H/0+okgPyrG4pqke1nZjr91nj bbWN9YrIAYMyrbRFsV4CtkOuf10bbymFo/BnH+obaWYyUrrozaH77LH1ojuMHUl2 bx5omR8S7wwp18YqxZBDHuMCQRsZb6G3qEFJtSWaNsmHMsEtowleqyQpyWZ3yeFG GkR+K1y24mFrvN6N/Y+QyE5WaAz35aIZ1wkdlad9MXfMHif087O5p90YOcBc7/lc DHGfEAJ1AgwmPx23JuL1wUtwVNP1wvP+ACmDLjEAWUNlzqfKAEFpUJi2G8jzUujn mLrrfx8zJJbufdfSbP+Ve8xjmLqnzRJAL2frzMfuj3Sf9fZeS3ekCtLLbbA5Vn8= =129k -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54E53B34.5070605>