Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Jan 2004 18:18:12 -0800 (PST)
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 45513 for review
Message-ID:  <200401180218.i0I2ICBR087482@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=45513

Change 45513 by jmallett@jmallett_oingo on 2004/01/17 18:17:28

	Trust the hardware to yell about bad PTEs for us.
	
	Suggested by:	cgd

Affected files ...

.. //depot/projects/mips/sys/mips/mips/exception.S#11 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/exception.S#11 (text+ko) ====

@@ -189,18 +189,10 @@
 	 */
 	ld	k1, 0(k1)
 	addu	k1, k0
-	ld	k0, 0(k1)	/* Even PTE. */
-	andi	k0, PG_V	/* Check validity. */
-	bne	k0, zero, 2f	/* Valid. */
-	nop
-	ld	k0, 8(k1)	/* Odd PTE. */
-	andi	k0, PG_V	/* Check validity. */
-	beq	k0, zero, 1f	/* Invalid. */
-	nop
 	/*
-	 * Valid PTE.  Write the pair.
+	 * Write the pair.
 	 */
-2:	ld	k0, 0(k1)	/* Even PTE. */
+	ld	k0, 0(k1)	/* Even PTE. */
 	ld	k1, 8(k1)	/* Odd PTE. */
 	/*
 	 * Write TLB entry.
@@ -212,30 +204,9 @@
 	nop
 	nop
 	eret
-1:	j	BadPTE
-	nop
-	.set at
 VEND(XTLBMissVector)
 
 /*
- * Yell about a bogus PTE, at 0(k1).
- */
-ENTRY(BadPTE)
-	.set noat
-	dmfc0	a3, MIPS_COP_0_BAD_VADDR
-	move	a1, k1
-	ld	a2, 0(k1)
-	dla	a0, 1f
-	dla	k0, panic
-	dmtc0	k0, MIPS_COP_0_EXC_PC
-	eret
-	.set at
-END(BadPTE)
-	.data
-1:	.asciiz	"Bad PTE at %p (%16lx), badvaddr %lx"
-	.text
-
-/*
  * Handle an interrupt.  Return into panic, for now.
  */
 LEAF(Interrupt)


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401180218.i0I2ICBR087482>