Date: Thu, 20 Apr 2017 17:43:25 +0000 (UTC) From: "Pedro F. Giffuni" <pfg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r317200 - head/lib/libthread_db Message-ID: <201704201743.v3KHhPdG014442@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: pfg Date: Thu Apr 20 17:43:25 2017 New Revision: 317200 URL: https://svnweb.freebsd.org/changeset/base/317200 Log: libthread_db: unsign map_len and use reallocarray(3). Lengths are not negative, so map_len should be unsigned. Unsign the corresponding indexes too and bring a small use of reallocarray(3). Reorder the memset to be consistent with the realloc: it appears we were only clearing half the memory in pt_map_thread(). MFC after: 2 weeks Modified: head/lib/libthread_db/libpthread_db.c head/lib/libthread_db/libpthread_db.h Modified: head/lib/libthread_db/libpthread_db.c ============================================================================== --- head/lib/libthread_db/libpthread_db.c Thu Apr 20 17:22:03 2017 (r317199) +++ head/lib/libthread_db/libpthread_db.c Thu Apr 20 17:43:25 2017 (r317200) @@ -74,7 +74,8 @@ pt_map_thread(const td_thragent_t *const { td_thragent_t *ta = __DECONST(td_thragent_t *, const_ta); struct pt_map *new; - int i, first = -1; + int first = -1; + unsigned int i; /* leave zero out */ for (i = 1; i < ta->map_len; ++i) { @@ -94,12 +95,12 @@ pt_map_thread(const td_thragent_t *const ta->map_len = 20; first = 1; } else { - new = realloc(ta->map, - sizeof(struct pt_map) * ta->map_len * 2); + new = reallocarray(ta->map, ta->map_len, + 2 * sizeof(struct pt_map)); if (new == NULL) return (-1); - memset(new + ta->map_len, '\0', sizeof(struct pt_map) * - ta->map_len); + memset(new + ta->map_len, '\0', ta->map_len * + 2 * sizeof(struct pt_map)); first = ta->map_len; ta->map = new; ta->map_len *= 2; @@ -1047,7 +1048,7 @@ pt_thr_sstep(const td_thrhandle_t *th, i static void pt_unmap_lwp(const td_thragent_t *ta, lwpid_t lwp) { - int i; + unsigned int i; for (i = 0; i < ta->map_len; ++i) { if (ta->map[i].type == PT_LWP && ta->map[i].lwp == lwp) { Modified: head/lib/libthread_db/libpthread_db.h ============================================================================== --- head/lib/libthread_db/libpthread_db.h Thu Apr 20 17:22:03 2017 (r317199) +++ head/lib/libthread_db/libpthread_db.h Thu Apr 20 17:43:25 2017 (r317200) @@ -77,7 +77,7 @@ struct td_thragent { int thread_off_sigmask; int thread_off_sigpend; struct pt_map *map; - int map_len; + unsigned int map_len; }; void pt_md_init(void);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704201743.v3KHhPdG014442>