Date: Fri, 19 Sep 2003 16:37:49 -0700 (PDT) From: Jeff Roberson <jeff@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/fs/nwfs nwfs_io.c src/sys/fs/smbfs smbfs_io.c src/sys/nfsclient nfs_bio.c Message-ID: <200309192337.h8JNbolJ070196@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jeff 2003/09/19 16:37:49 PDT
FreeBSD src repository
Modified files:
sys/fs/nwfs nwfs_io.c
sys/fs/smbfs smbfs_io.c
sys/nfsclient nfs_bio.c
Log:
- Remove interlock protection around VI_XLOCK. The interlock is not
sufficient to guarantee that this race is not hit. The XLOCK will likely
have to be redesigned due to the way reference counting and mutexes work
in FreeBSD. We currently can not be guaranteed that xlock was not set
and cleared while we were blocked on the interlock while waiting to check
for XLOCK. This would lead us to reference a vnode which was not the
vnode we requested.
- Add a backtrace() call inside of INVARIANTS in the hopes of finding out if
this condition is ever hit. It should not, since we should be retaining
a reference to the vnode in these cases. The reference would be sufficient
to block recycling.
Revision Changes Path
1.30 +3 -3 src/sys/fs/nwfs/nwfs_io.c
1.23 +3 -3 src/sys/fs/smbfs/smbfs_io.c
1.121 +3 -4 src/sys/nfsclient/nfs_bio.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309192337.h8JNbolJ070196>