Date: Sat, 10 Sep 2022 09:34:38 GMT From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 13018bfae80f - main - ip_reass: make stray callout assertion more verbose Message-ID: <202209100934.28A9YcEX064055@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=13018bfae80f10bfcd6aad1fbe3e3feb24ffe353 commit 13018bfae80f10bfcd6aad1fbe3e3feb24ffe353 Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2022-09-10 09:11:39 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2022-09-10 09:11:39 +0000 ip_reass: make stray callout assertion more verbose Syzcaller hits this assertion, but can't find reproducer. I also never seen it hit in my testing. Try to get more information via syzcaller. --- sys/netinet/ip_reass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c index 5227b1387c69..aa5c99a3624c 100644 --- a/sys/netinet/ip_reass.c +++ b/sys/netinet/ip_reass.c @@ -600,7 +600,8 @@ ipreass_callout(void *arg) CURVNET_SET(bucket->vnet); fp = TAILQ_LAST(&bucket->head, ipqhead); KASSERT(fp != NULL && fp->ipq_expire >= time_uptime, - ("%s: stray callout on bucket %p", __func__, bucket)); + ("%s: stray callout on bucket %p, %ju < %ju", __func__, bucket, + fp ? (uintmax_t)fp->ipq_expire : 0, (uintmax_t)time_uptime)); while (fp != NULL && fp->ipq_expire >= time_uptime) { ipq_timeout(bucket, fp);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202209100934.28A9YcEX064055>