Date: Wed, 30 Oct 2013 14:23:01 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: ports/183470: [options] support multivalue sets in ${opt}_USE
Message-ID: <20131030102301.C3B2CFA1@hades.panopticon>
Resent-Message-ID: <201310301030.r9UAU04K061726@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 183470
>Category: ports
>Synopsis: [options] support multivalue sets in ${opt}_USE
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 30 10:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Marakasov
>Release: FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0 r251956: Tue Jun 18 21:41:37 MSK 2013 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64
>Description:
Currently, framework won't support
OPTIONS_DEFINE= X11
X11_USE= XORG="x11 sm ice"
because it considers "x11 sm ice" a single value.
The patch attached removes quites so above code works as expected.
While here, I'd like to suggest to merge USE_* with USES, so the code below work:
USES= gettext gmake XORG="x11 sm ice" QT="corelib gui"
OPTIONS_DEFINE= OGL
OGL_USE= GL="gl glu"
>How-To-Repeat:
>Fix:
--- bsd.options.mk.patch begins here ---
Index: Mk/bsd.options.mk
===================================================================
--- Mk/bsd.options.mk (revision 332092)
+++ Mk/bsd.options.mk (working copy)
@@ -387,7 +387,7 @@
. if defined(${opt}_USE)
. for option in ${${opt}_USE}
_u= ${option:C/=.*//g}
-USE_${_u:U}+= ${option:C/.*=//g}
+USE_${_u:U}+= ${option:C/.*=//g:C/^"//:C/"$$//}
. endfor
. endif
. if defined(${opt}_CONFIGURE_ENABLE)
--- bsd.options.mk.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131030102301.C3B2CFA1>