Date: Fri, 10 Mar 2000 10:21:15 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: current@FreeBSD.org Cc: oogali@intranova.net Subject: inetd broken w/o INET6 Message-ID: <200003101521.KAA66327@server.baldwin.cx>
next in thread | raw e-mail | index | archive | help
It appears inetd is broken if you don't have INET6 defined. This is
the case for picoBSD, for example:
> make -DRELEASE_CRUNCH
cc -O -pipe -Wall -DLOGIN_CAP -c /usr/source/src/usr.sbin/inetd/inetd.c
/usr/source/src/usr.sbin/inetd/inetd.c: In function `getconfigent':
/usr/source/src/usr.sbin/inetd/inetd.c:1594: syntax error before `else'
/usr/source/src/usr.sbin/inetd/inetd.c:1435: warning: unused variable `s'
/usr/source/src/usr.sbin/inetd/inetd.c:1434: warning: unused variable `argc'
/usr/source/src/usr.sbin/inetd/inetd.c: At top level:
/usr/source/src/usr.sbin/inetd/inetd.c:1601: syntax error before `->'
/usr/source/src/usr.sbin/inetd/inetd.c:1601: warning: type defaults to `int' in declaration of
`se_family'
/usr/source/src/usr.sbin/inetd/inetd.c:1601: warning: data definition has no type or storage class
/usr/source/src/usr.sbin/inetd/inetd.c:1602: syntax error before `}'
*** Error code 1
Stop in /usr/source/src/usr.sbin/inetd.
I've fixed this and another INET6-related warning with this patch:
Index: builtins.c
===================================================================
RCS file: /usr/cvs/src/usr.sbin/inetd/builtins.c,v
retrieving revision 1.17
diff -u -r1.17 builtins.c
--- builtins.c 2000/01/25 14:52:09 1.17
+++ builtins.c 2000/03/10 15:13:35
@@ -335,7 +335,9 @@
struct utsname un;
struct stat sb;
struct sockaddr_in sin[2];
+#ifdef INET6
struct sockaddr_in6 sin6[2];
+#endif
struct sockaddr_storage ss[2];
struct ucred uc;
struct timeval tv = {
Index: inetd.c
===================================================================
RCS file: /usr/cvs/src/usr.sbin/inetd/inetd.c,v
retrieving revision 1.79
diff -u -r1.79 inetd.c
--- inetd.c 2000/02/22 00:27:53 1.79
+++ inetd.c 2000/03/10 15:13:08
@@ -1590,8 +1590,8 @@
if (v4bind == 0 || no_v4bind != 0)
sep->se_nomapped = 1;
}
-#endif
else { /* default to v4 bind if not v6 bind */
+#endif
if (no_v4bind != 0) {
syslog(LOG_INFO, "IPv4 bind is ignored for %s",
sep->se_service);
@@ -1599,7 +1599,9 @@
goto more;
}
sep->se_family = AF_INET;
+#ifdef INET6
}
+#endif
/* init ctladdr */
switch(sep->se_family) {
case AF_INET:
This patch can also be found at
http://people.FreeBSD.org/~jhb/patches/inetd.patch
--
John Baldwin <jobaldwi@vt.edu> -- http://www.cslab.vt.edu/~jobaldwi/
PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003101521.KAA66327>