Date: Fri, 16 Jun 2017 16:53:58 +0100 From: Andrew Turner <andrew@fubar.geek.nz> To: Zbigniew Bodek <zbb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320002 - head/sys/arm/arm Message-ID: <7A647614-6401-42EE-B843-54F9D15A0749@fubar.geek.nz> In-Reply-To: <201706161353.v5GDr2ig085413@repo.freebsd.org> References: <201706161353.v5GDr2ig085413@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 16 Jun 2017, at 14:53, Zbigniew Bodek <zbb@freebsd.org> wrote: >=20 > Author: zbb > Date: Fri Jun 16 13:53:02 2017 > New Revision: 320002 > URL: https://svnweb.freebsd.org/changeset/base/320002 >=20 > Log: > Minor style improvements to pmap_remap_vm_attr() >=20 > Use correct platform_ function name in the comment and remove > redundant tabs. >=20 > Modified: > head/sys/arm/arm/pmap-v6.c >=20 > Modified: head/sys/arm/arm/pmap-v6.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/arm/arm/pmap-v6.c Fri Jun 16 10:16:24 2017 = (r320001) > +++ head/sys/arm/arm/pmap-v6.c Fri Jun 16 13:53:02 2017 = (r320002) > @@ -508,7 +508,7 @@ pmap_set_tex(void) > * Usage rules: > * - it shall be called after pmap_bootstrap_prepare() and before > * cpu_mp_start() (thus only on boot CPU). In practice, it's = expected > - * to be called from platform_attach() or platform_late_init(). > + * to be called from platform_probe_and_attach() or = platform_late_init(). That was correct. The armv6 SoC code should be using PLATFORM and = implement the platform_attach() method. It=E2=80=99s a bug the Marvell = code doesn=E2=80=99t. Andrew=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7A647614-6401-42EE-B843-54F9D15A0749>