Date: Thu, 25 May 2023 07:14:06 +0900 From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> To: dev-commits-src-main@freebsd.org Cc: Randall Stewart <rrs@netflix.com> Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. Message-ID: <20230525071406.c5ea33f08fd27adb0c39f158@dec.sakura.ne.jp> In-Reply-To: <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com> References: <20230522070643.99f8aa0c5509c0d3a5f2ae0b@dec.sakura.ne.jp> <1E5C3216-1A6F-43AC-AA91-24FA1EA18842@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 23 May 2023 09:59:33 -0400 Randall Stewart <rrs@netflix.com> wrote: > > https://reviews.freebsd.org/D40229 <https://reviews.freebsd.org/D40229>; > > Should fix this :) > > R > > On May 21, 2023, at 6:06 PM, Tomoaki AOKI <junchoon@dec.sakura.ne.jp> wrote: > > > >> On Tue, Apr 4, 2023 at 12:31 PM Randall Stewart <rrs@freebsd.org> wrote: > >>> > >>> The branch main has been updated by rrs: > >>> > >>> URL: https://www.google.com/url?q=https://cgit.FreeBSD.org/src/commit/?id%3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f&source=gmail-imap&ust=1685311614000000&usg=AOvVaw0HmtU6ylNo8jRrPgvtzIB0 > >>> > >>> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > >>> Author: Randall Stewart <rrs@FreeBSD.org> > >>> AuthorDate: 2023-04-01 05:46:38 +0000 > >>> Commit: Randall Stewart <rrs@FreeBSD.org> > >>> CommitDate: 2023-04-01 05:46:38 +0000 > >>> > >>> Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. > >>> > >>> So stack switching as always been a bit of a issue. We currently use a break before make setup which means that > >>> if something goes wrong you have to try to get back to a stack. This patch among a lot of other things changes that so > >>> that it is a make before break. We also expand some of the function blocks in prep for new features in rack that will allow > >>> more controlled pacing. We also add other abilities such as the pathway for a stack to query a previous stack to acquire from > >>> it critical state information so things in flight don't get dropped or mis-handled when switching stacks. We also add the > >>> concept of a timer granularity. This allows an alternate stack to change from the old ticks granularity to microseconds and > >>> of course this even gives us a pathway to go to nanosecond timekeeping if we need to (something for the data center to consider > >>> for sure). > >>> > >>> Once all this lands I will then update rack to begin using all these new features. > >>> > >>> Reviewed by: tuexen > >>> Sponsored by: Netflix Inc > >>> Differential Revision: https://www.google.com/url?q=https://reviews.freebsd.org/D39210&source=gmail-imap&ust=1685311614000000&usg=AOvVaw1ZouYiMywAnpdYyYCp9T9O > >> > >> Hi, > >> > >> Could you hide some stuff in netinet/tcp.h? > >> struct http_req breaks curl 8.1.0. > >> > >> Antoine > > > > Please refer to Bug 271526 [1], especially Comment 4 [2] by Jonathan > > Reynolds. > > A patch is proposed there inline (not as an attachment). > > > > [1] https://www.google.com/url?q=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id%3D271526&source=gmail-imap&ust=1685311614000000&usg=AOvVaw2e-0D0bz7CAIVj6kvLZOJg > > > > [2] https://www.google.com/url?q=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id%3D271526%23c4&source=gmail-imap&ust=1685311614000000&usg=AOvVaw154j12MkBXKn2z9_gepR1n > > > > -- > > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > > ------ > Randall Stewart > rrs@netflix.com Thanks! ftp/curl 8.1 built fine with your diff. What's done: Back out the patch at Bug 271526 Apply your diff at D40229 Forcibly rebuild/reinstall base as usual and reboot Forcibly rebuild ftp/curl, which is still before 8.1.1 base is at commit 902dc544cc5859e24c727126e45416133c1c6d46, amd64. Regards. -- Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230525071406.c5ea33f08fd27adb0c39f158>