Date: Tue, 21 Feb 2017 02:35:10 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Bruce Evans <brde@optusnet.com.au> Cc: Hans Petter Selasky <hps@selasky.org>, Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313859 - in head/sys: kern sys Message-ID: <20170221013510.GF26759@dft-labs.eu> In-Reply-To: <20170217203028.K2144@besplex.bde.org> References: <201702170645.v1H6j4l6060548@repo.freebsd.org> <2c01557a-3412-8b46-ef4d-77214566b74a@selasky.org> <20170217203028.K2144@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 17, 2017 at 09:15:00PM +1100, Bruce Evans wrote: > On Fri, 17 Feb 2017, Hans Petter Selasky wrote: > > >>Log: > >> Introduce SCHEDULER_STOPPED_TD for use when the thread pointer > >>was already read > >> > >> Sprinkle in few places. > >> > >>Modified: > >> head/sys/kern/kern_condvar.c > >> head/sys/kern/kern_synch.c > >> head/sys/sys/systm.h > > > >Do these checks also cover panics? Or only shutdown? > > This is just an optimization. > > I don't like it because it moves further from moving the stopped flag > back out of the thread to a global. > I only did this to make it more feasible to remove the tid argument from primitives which I may or may not end up doing, undecided yet. As for changing the conditon to testing a global, I don't think this change affects feasibilitly. It onlly requires some more churn by hand which I'm happy to do if said change is implemented. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170221013510.GF26759>