Date: Sat, 14 Jan 2012 15:30:15 +0000 From: Chris Rees <crees@freebsd.org> To: Rainer Hurling <rhurlin@gwdg.de> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: HEADS UP: set_rcvar() removed from rc.subr Message-ID: <CADLo838LsSkHjM7JFQEqfC6D5R29he%2BfjgxaBho_S7EdEzZgZA@mail.gmail.com> In-Reply-To: <4F119C40.2080503@gwdg.de> References: <4F114577.30201@FreeBSD.org> <4F119C40.2080503@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 January 2012 15:16, Rainer Hurling <rhurlin@gwdg.de> wrote:
> On 14.01.2012 10:05 (UTC+1), Doug Barton wrote:
>>
>> Howdy,
>>
>> Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr.
>> The concept of set_rcvar() was nice in theory, but the forks it creates
>> are a drag on the startup process, which is especially noticeable on
>> slower systems, such as embedded ones.
>>
>> I have no plans to MFC this change, so it should only affect users who
>> are actually on 10-current. If you have scripts in /usr/local/etc/rc.d
>> (which if you have ports installed you almost certainly do) ...
>>
>> to make the change by hand, change this:
>>
>> name=3Dfoo
>> rcvar=3D`set_rcvar`
>>
>> to:
>>
>> name=3Dfoo
>> rcvar=3Dfoo_enable
>>
>> I didn't bump PORTREVISIONs because the change only applies to HEAD. But
>> all of the ports are updated, so if you can't figure out how to make the
>> change, just reinstall it.
>>
>>
>> Doug
>
>
> Seems that ports-mgmt/tinderbox needs an update like this:
>
> files/patch-etc__rc.d__tinderd
>
> --- etc/rc.d/tinderd.orig =A0 =A0 =A0 2011-11-20 07:01:09.000000000 +0100
> +++ etc/rc.d/tinderd =A0 =A02012-01-14 16:07:38.000000000 +0100
> @@ -16,7 +16,7 @@
> =A0. /etc/rc.subr
>
> =A0name=3D"tinderd"
> -rcvar=3D`set_rcvar`
> +rcvar=3Dtinderd_enable
>
> =A0# read settings, set default values
> =A0load_rc_config "${name}"
>
I'm in the process of fixing this upstream.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838LsSkHjM7JFQEqfC6D5R29he%2BfjgxaBho_S7EdEzZgZA>