Date: Mon, 19 Jan 1998 23:45:25 -0600 (CST) From: Joel Ray Holveck <joelh@gnu.org> To: freebsd-hackers@FreeBSD.ORG Subject: syscons.c Mode X handling Message-ID: <199801200545.XAA00312@detlev.UUCP>
next in thread | raw e-mail | index | archive | help
I'll be the first to admit that I don't know a thing about VGA programming, but, unless I'm wrong, there is definately something awry in this bit of code, from syscons.c:set_mode, in case M_VGA_MODEX, line 4055. This could be perfectly harmless, but special_modetable[10+0x11] gets set twice before anything is done with it. (special_modetable is a normal char array on the stack.) Anybody know what's going on here? This isn't anything that's important to my work, I just came across it while going over the mode-switching code, and it looks funny. /* set 240 lines */ special_modetable[10+0x11] = 0x2c; special_modetable[10+0x06] = 0x0d; special_modetable[10+0x07] = 0x3e; special_modetable[10+0x10] = 0xea; special_modetable[10+0x11] = 0xac; Happy hacking, joelh -- Joel Ray Holveck - joelh@gnu.org - http://www.wp.com/piquan Fourth law of programming: Anything that can go wrong wi sendmail: segmentation violation - core dumped
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801200545.XAA00312>