Date: Sat, 11 Sep 2010 10:00:31 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/socket/files patch-ag Message-ID: <20100911100031.GB98291@FreeBSD.org> In-Reply-To: <4C89CF37.5090502@p6m7g8.com> References: <201009092255.o89MtTei055181@repoman.freebsd.org> <20100910033223.GA72617@FreeBSD.org> <4C89CF37.5090502@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 10, 2010 at 06:24:55AM +0000, Philip M. Gollucci wrote: > On 09/10/10 03:32, Alexey Dokuchaev wrote: > > Per PH section 4.4: > > > > "Do not name your patches like patch-aa or patch-ab etc, always mention > > path and file name in patch names." > > I had very good reasons for doing this: > > 1) I didn't want to regen the existing patches patch-a* Absolutely. New rules apply only to new patches. > 2) Doing #1 actually cause the patches not to apply in an > incredibly difficult manner. Well, since #1 does not apply, there is not problem, right? > 3) If it was a port I maintained instead of fixing a long timed out pr > I would have spent the extra effort and time to fix this. > > How about instead of replying to 1/2 of everyone's commits you commit > some of your own prs so I can reply to them ? Sure, please feel free, I'm always open for feedback. Commit stats can be found e.g. at http://cia.vc/stats/author/<committer>; ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100911100031.GB98291>