Date: Thu, 27 Aug 2015 11:01:23 +0200 From: Julien Charbon <jch@freebsd.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, John Baldwin <jhb@freebsd.org>, Adrian Chadd <adrian@freebsd.org> Subject: Re: svn commit: r286880 - head/sys/kern Message-ID: <55DED1E3.3090004@freebsd.org> In-Reply-To: <55DE0615.5050303@selasky.org> References: <201508181015.t7IAFAex055889@repo.freebsd.org> <55DD69E5.4090904@selasky.org> <55DD74EB.30601@selasky.org> <55DE01F7.8040508@freebsd.org> <55DE0615.5050303@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Hans, On 26/08/15 20:31, Hans Petter Selasky wrote: > On 08/26/15 20:14, Julien Charbon wrote: >> Let say that if nobody screams until Friday 8/28, I will put back >> r284245 and revert this change_and_ I will make this case clear in th= e >> man page. >=20 > If you can update the manual page about this special case for MPSAFE > callouts only I presume, then its totally fine. Good idea, I am going to update the callout(9) man page to make clear that in mpsafe case if a callout is pending and currently being serviced callout_stop() returns 0 (fail). > Then I can update my projects/hps_head to follow that new change, > which now is a bit broken. You might also want to check existing > MPSAFE consumers in the kernel, if this API change makes any > difference. I checked all the mpsafe callouts that check callout_stop() return value (actually only a few are testing callout_stop() return value), and none relies on the old behavior (i.e. before r286880). > I was thinking if user-space TCP might be affected by this. CC'ing Adri= an. Interesting. -- Julien --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJV3tHjAAoJEKVlQ5Je6dhxubYH/A4MsY+FJnJAzbwqiOF2Hub1 mIKHGurrsBTbIsv3E3rOyBFDdu7cK0vMulwmbNWSLzoyviCK14FMIn+LCkhYEKTl NMrXbVR1wSfP7DcrOM1JvqV+PyKRjhyAKPrhTfHlR7SwfTxypFof8d+1c9JvyWY+ SAqSqqNUIEBr4qf+ksVFWKm6qv3a0wZjnVUwtkGSjBQgTtvjKUUvM7SUv8cV6HJV 0y4a9pP/06nwXV08TQ2pZv9Ew8x8IDQ6LvAr2uKLOEIGKXXcF+wyc4HZE3sZx3cv md7jOOAwsTOon9FpwWsLkEQbb7Xhi/w4Xw412/hzJQ0449xzyCV4NF8519Pq3hQ= =khMM -----END PGP SIGNATURE----- --4R9tPBdsfipjFOhLP6q0450aqq7PicPxq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55DED1E3.3090004>