Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 20:32:23 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c8828fec0540 - stable/13 - TCP BBR: remove code which is never executed
Message-ID:  <202502052032.515KWNT7062621@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=c8828fec054096216574882b8bcc85d2548cbbd6

commit c8828fec054096216574882b8bcc85d2548cbbd6
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-01 17:39:23 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 20:17:38 +0000

    TCP BBR: remove code which is never executed
    
    USEC_2_TICKS() returns at least 1.
    
    Reviewed by:            rrs
    CID:                    1523775
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D4827
    
    (cherry picked from commit 1781324db2bc22a971a33c5a063036b2775055c6)
---
 sys/netinet/tcp_stacks/bbr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c
index 732879dfab47..cf3317d790c3 100644
--- a/sys/netinet/tcp_stacks/bbr.c
+++ b/sys/netinet/tcp_stacks/bbr.c
@@ -6359,8 +6359,6 @@ tcp_bbr_xmit_timer_commit(struct tcp_bbr *bbr, struct tcpcb *tp, uint32_t cts)
 	}
 	/* Round it up */
 	rtt_ticks = USEC_2_TICKS((rtt + (USECS_IN_MSEC - 1)));
-	if (rtt_ticks == 0)
-		rtt_ticks = 1;
 	if (tp->t_srtt != 0) {
 		/*
 		 * srtt is stored as fixed point with 5 bits after the



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502052032.515KWNT7062621>