Date: Fri, 24 Oct 2008 20:51:57 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Jaakko Heinonen <jh@saunalahti.fi>, src-committers@FreeBSD.org Subject: Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev/... Message-ID: <20081024204301.A72819@delplex.bde.org> In-Reply-To: <86ej27xgzy.fsf@ds4.des.no> References: <200810231553.m9NFrqQj060598@svn.freebsd.org> <20081023184621.GA32081@ws64.jh.dy.fi> <86ej27xgzy.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Oct 2008, [utf-8] Dag-Erling Smørgrav wrote:
> Jaakko Heinonen <jh@saunalahti.fi> writes:
>> This change introduces some bad formatting. Many statements would now
>> fit to 80 columns and don't need to be wrapped.
>
> You're right, and I'd appreciate a patch, if you feel like it - but not
> right away, as I'm about to revert the net80211 parts of the commit.
>
>> There are also places with unnecessary white space:
>
> They were already broken, and I didn't want to mix style changes with
> code changes.
Actually, at least the first 6 weren't broken, but were broken by mixing
style changes with the code changes. The first 1 is:
% Modified: head/sys/contrib/altq/altq/altq_hfsc.c
% ==============================================================================
% --- head/sys/contrib/altq/altq/altq_hfsc.c Thu Oct 23 15:44:00 2008 (r184204)
% +++ head/sys/contrib/altq/altq/altq_hfsc.c Thu Oct 23 15:53:51 2008 (r184205)
% ...
% @@ -471,8 +471,7 @@ hfsc_class_create(struct hfsc_if *hif, s
% #endif /* ALTQ_RED */
%
% if (rsc != NULL && (rsc->m1 != 0 || rsc->m2 != 0)) {
% - MALLOC(cl->cl_rsc, struct internal_sc *,
% - sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
% + cl->cl_rsc = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK);
% if (cl->cl_rsc == NULL)
% goto err_ret;
% sc2isc(rsc, cl->cl_rsc);
Here the sizeof() was perfectly indented, with 2 tabs and then 4 spaces
for a continuation line. A dumb sed script appears to have been run
over this blindly. It duplicated the 2 tabs and 4 spaces, which would
have been OK if it didn't also join the lines by removing only the
newline, leaving weird whitespace after "malloc(".
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081024204301.A72819>