Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Mar 2026 01:14:59 +0000
From:      Philip Paeps <philip@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Cc:        Kristof Provost <kp@FreeBSD.org>
Subject:   git: a429dbb47ff6 - releng/14.4 - pfctl: always warn if a duplicate rule was detected
Message-ID:  <69c48893.18d98.456a5d26@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch releng/14.4 has been updated by philip:

URL: https://cgit.FreeBSD.org/src/commit/?id=a429dbb47ff638934ab5f9768af13165e6ca2dc0

commit a429dbb47ff638934ab5f9768af13165e6ca2dc0
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2026-03-12 14:24:42 +0000
Commit:     Philip Paeps <philip@FreeBSD.org>
CommitDate: 2026-03-25 16:11:03 +0000

    pfctl: always warn if a duplicate rule was detected
    
    Approved by:    so
    Security:       FreeBSD-SA:26:09.pf
    Security:       CVE-2026-4748
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit 66d66dd0f6f83926980fc1d68dd366c0057350c5)
    (cherry picked from commit e79818ec36efafc994d8c5a912dcb94986c038c5)
---
 sbin/pfctl/pfctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c
index d6bb0ae7f46f..518b32085565 100644
--- a/sbin/pfctl/pfctl.c
+++ b/sbin/pfctl/pfctl.c
@@ -2043,13 +2043,13 @@ pfctl_load_rule(struct pfctl *pf, char *path, struct pfctl_rule *r, int depth)
 		}
 	}
 
-	if (pf->opts & PF_OPT_VERBOSE) {
+	if (pf->opts & PF_OPT_VERBOSE || was_present) {
 		INDENT(depth, !(pf->opts & PF_OPT_VERBOSE2));
 		print_rule(r, name,
 		    pf->opts & PF_OPT_VERBOSE2,
 		    pf->opts & PF_OPT_NUMERIC);
 		if (was_present)
-			printf(" -- rule was already present");
+			printf(" -- rule was already present\n");
 	}
 	path[len] = '\0';
 	pfctl_clear_pool(&r->rpool);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69c48893.18d98.456a5d26>