Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Oct 2011 12:43:13 -0700
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Ed Schouten <ed@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r225897 - head/lib/libc/gen
Message-ID:  <CAGH67wRGCwbomoChsKDe9fgXqrg%2BzWXX3_nnybNtNVCpgbkOcw@mail.gmail.com>
In-Reply-To: <201110011219.p91CJmTc016767@svn.freebsd.org>
References:  <201110011219.p91CJmTc016767@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sat, Oct 1, 2011 at 5:19 AM, Ed Schouten <ed@freebsd.org> wrote:
> Author: ed
> Date: Sat Oct  1 12:19:48 2011
> New Revision: 225897
> URL: http://svn.freebsd.org/changeset/base/225897

...

> +       if (s == NULL) {
> +               s = def;
> +               dlen = sizeof(def) - LEN_PATH_DEV;
> +       } else
> +               dlen = L_ctermid - LEN_PATH_DEV;
> +       strcpy(s, _PATH_TTY);

Why not use strlcpy, etc with dlen?

-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wRGCwbomoChsKDe9fgXqrg%2BzWXX3_nnybNtNVCpgbkOcw>