Date: Mon, 25 Aug 2014 10:06:33 -0400 From: Adam Weinberger <adamw@adamw.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r365735 - in head/games: . prboom-plus Message-ID: <30BF3C98-F800-406C-AAEF-6FC3E0ABF01C@adamw.org> In-Reply-To: <53FB4122.3060402@marino.st> References: <201408231404.s7NE4Ds7036892@svn.freebsd.org> <20140825093243.GC66191@FreeBSD.org> <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> <53FB3FB3.90508@marino.st> <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org> <53FB4122.3060402@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Aug, 2014, at 9:58, John Marino <freebsd.contact@marino.st> wrote: > On 8/25/2014 15:55, Adam Weinberger wrote: >> On 25 Aug, 2014, at 9:52, John Marino <freebsd.contact@marino.st> = wrote: >>=20 >>> On 8/25/2014 15:43, Adam Weinberger wrote: >>>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org> >>>> wrote: >>>>> COMMENT line is wrong. :) >>>>=20 >>>> Because it starts with an article? I=92d posit that that article >>>> improves readability of this particular COMMENT. >>>=20 >>> Yes, because it starts with an article. We've been instructed to >>> remove them unconditionally. >>> Hundreds of ports have comments equivalent to "Fork of the doom game >>> engine prboom", so it's not special in any way. >>>=20 >>> Unfortunately portlint doesn't check for this. I'd add this to the >>> current catch-all portlint rule PR. >>=20 >> Guys, if it=92s not right, please just fix it! >>=20 >=20 > It's more than that -- Let's say you really think starting with "A " = is > essential not matter what the rule is, then it makes sense to discuss = it > to prevent it in the future. It's not being lazy or critical, it's > educating. At least I believe that is the intent. I have worked quite hard the last few days to commit all staging PRs, = clear out nearly every patch-ready PR, and a lot of other PRs too. I = missed one article in one COMMENT. I missed it because it read quite = clearly. But sure, please re-educate me. Clearly I believe that adding articles = is essential no matter what the rule is. You discovered my secret = subversive mission. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30BF3C98-F800-406C-AAEF-6FC3E0ABF01C>