Date: Wed, 30 Jan 2008 13:36:04 -0800 From: Sam Leffler <sam@errno.com> To: Alexander Motin <mav@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h Message-ID: <47A0EDC4.3040301@errno.com> In-Reply-To: <200801302124.m0ULOANe012024@repoman.freebsd.org> References: <200801302124.m0ULOANe012024@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin wrote:
> mav 2008-01-30 21:24:10 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/sys proc.h
> Log:
> Implement GET_STACK_USAGE() macro to get the current kernel thread stack usage.
> This implemntation made for growing down stack organization like i386/amd64
> platforms have, but prefers different machine dependent version if it is present.
>
I think it is a mistake to fallback to a MD implementation; your MI
implementation is broken on architectures that do not use the model you
used so you any user of this will silently fail on such architectures.
I suggest you need to fix this before you use this macro in any MI code.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47A0EDC4.3040301>