Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Feb 2017 08:24:43 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-net@FreeBSD.org
Subject:   [Bug 213015] openvswitch and vnet jails -  panic when bridge is destroyed and recreated
Message-ID:  <bug-213015-2472-G3gZtDgQXv@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-213015-2472@https.bugs.freebsd.org/bugzilla/>
References:  <bug-213015-2472@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213015

--- Comment #9 from akoshibe@gmail.com ---
I finally had the chance to dig around more, myself.

Open vSwitch seems to try to write something when a new switch is being cre=
ated
with ports. It would sometimes do so while the tap device is in the process=
 of
being renamed, and ifp->if_bpf is null.

Preventing the departure handler from setting if_bpf to null during renames
stopped the panic:


Index: net/bpf.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- net/bpf.c   (revision 313973)
+++ net/bpf.c   (working copy)
@@ -2678,6 +2678,9 @@
        struct bpf_if *bp, *bp_temp;
        int nmatched =3D 0;

+       if (ifp->if_flags & IFF_RENAMING)
+               return;
+
        BPF_LOCK();
        /*
         * Find matching entries in free list.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213015-2472-G3gZtDgQXv>