Date: Thu, 11 Feb 2016 11:50:31 +0000 (UTC) From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r295510 - head/sys/dev/xen/netfront Message-ID: <201602111150.u1BBoVA9047382@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: royger Date: Thu Feb 11 11:50:31 2016 New Revision: 295510 URL: https://svnweb.freebsd.org/changeset/base/295510 Log: xen-netfront: remove pointless assignment in xn_ioctl The variable error is assigned to 0 before entering the switch. Assigning error to 0 before break pointless rewrites the real error value that should be returned. Coverity ID: 1304974 Submitted by: Wei Liu <wei.liu2@citrix.com> Reviewed by: royger Sponsored by: Citrix Systems R&D Differential revision: https://reviews.freebsd.org/D5250 Modified: head/sys/dev/xen/netfront/netfront.c Modified: head/sys/dev/xen/netfront/netfront.c ============================================================================== --- head/sys/dev/xen/netfront/netfront.c Thu Feb 11 11:49:27 2016 (r295509) +++ head/sys/dev/xen/netfront/netfront.c Thu Feb 11 11:50:31 2016 (r295510) @@ -1863,7 +1863,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, } sc->xn_if_flags = ifp->if_flags; XN_UNLOCK(sc); - error = 0; break; case SIOCSIFCAP: mask = ifr->ifr_reqcap ^ ifp->if_capenable; @@ -1898,7 +1897,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, ifp->if_capenable ^= IFCAP_LRO; } - error = 0; break; case SIOCADDMULTI: case SIOCDELMULTI:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602111150.u1BBoVA9047382>