Date: Tue, 31 Mar 2015 09:36:39 -0400 From: John Baldwin <jhb@freebsd.org> To: Randall Stewart <rrs@netflix.com> Cc: Davide Italiano <davide@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Message-ID: <3203943.oAr2O9rG4a@ralph.baldwin.cx> In-Reply-To: <A9C1225A-C1A1-49BD-977D-572F4C145F51@netflix.com> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <3218826.nq4nR2EqCz@ralph.baldwin.cx> <A9C1225A-C1A1-49BD-977D-572F4C145F51@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, March 30, 2015 04:21:03 PM Randall Stewart wrote: > John: > > As I just said, Warner and I feel we can get by with making the int -> short/short so > we preserver the KPI and at the same time achieve the objective .. > > My big concern was no intel platforms but Warner gave me a green light there ;-) Technically this still breaks the KBI (in that existing drivers using callout_pending(), callout_active(), and callout_deactivate() will not do the correct thing). OTOH, you can't preserve that and still fix the race (well, unless you do locking in callout_deactivate() which you might consider for an MFC even if you didn't do it in HEAD if the KBI breakage is severe enough). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3203943.oAr2O9rG4a>