Date: Mon, 25 Nov 2019 17:23:25 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Ryan Libby <rlibby@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r355089 - stable/12/sys/x86/include Message-ID: <20191125152325.GE10580@kib.kiev.ua> In-Reply-To: <CAHgpiFyGgvw0XPj80N3O_xEysiQ0ZON_rxOOQWpPjCF8XJR7qg@mail.gmail.com> References: <201911251418.xAPEItMH087104@repo.freebsd.org> <CAHgpiFyGgvw0XPj80N3O_xEysiQ0ZON_rxOOQWpPjCF8XJR7qg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 25, 2019 at 06:58:27AM -0800, Ryan Libby wrote: > On Mon, Nov 25, 2019 at 6:19 AM Konstantin Belousov <kib@freebsd.org> wrote: > > > > Author: kib > > Date: Mon Nov 25 14:18:55 2019 > > New Revision: 355089 > > URL: https://svnweb.freebsd.org/changeset/base/355089 > > > > Log: > > MFC r355088: > > Limit bus_dma_dmar_set_buswide() definition to kernel only. > > > > Modified: > > stable/12/sys/x86/include/bus_dma.h > > Directory Properties: > > stable/12/ (props changed) > > > > Modified: stable/12/sys/x86/include/bus_dma.h > > ============================================================================== > > --- stable/12/sys/x86/include/bus_dma.h Mon Nov 25 14:16:41 2019 (r355088) > > +++ stable/12/sys/x86/include/bus_dma.h Mon Nov 25 14:18:55 2019 (r355089) > > @@ -179,7 +179,9 @@ _bus_dmamap_complete(bus_dma_tag_t dmat, bus_dmamap_t > > return (tc->impl->map_complete(dmat, map, segs, nsegs, error)); > > } > > > > +#ifdef _KERNEL > > bool bus_dma_dmar_set_buswide(device_t dev); > > +#endif > > > > #endif /* !_X86_BUS_DMA_H_ */ > > > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > No complaint, but incidentally I think this didn't trip in current > because r347836 deleted #include <machine/bus.h> from camdd.c. I see, thank you. I will keep this #ifdef around for some time in HEAD as well. If the revision ever get merged into 12, I remove the braces from both branches.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191125152325.GE10580>