Date: Fri, 16 Aug 2002 01:20:05 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/36219: poll() behaves erratic on BPF file descriptors. Message-ID: <200208160820.g7G8K5Yo033664@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/36219; it has been noted by GNATS.
From: Bruce Evans <bde@zeta.org.au>
To: Lev Walkin <vlm@netli.com>
Cc: Nate Lawson <nate@root.org>, <freebsd-gnats-submit@FreeBSD.org>,
<gad@FreeBSD.org>, <bde@FreeBSD.org>
Subject: Re: kern/36219: poll() behaves erratic on BPF file descriptors.
Date: Fri, 16 Aug 2002 18:17:53 +1000 (EST)
On Thu, 15 Aug 2002, Lev Walkin wrote:
> Nate Lawson wrote:
> > I looked over the current state of bpf.c and it seems like this PR can be
> > closed. Comments?
> >
> > if (events & (POLLIN | POLLRDNORM)) {
> > /*
> > * An imitation of the FIONREAD ioctl code.
> > * XXX not quite. An exact imitation:
> > *if (d->b_slen != 0 ||
> > * (d->bd_hbuf != NULL && d->bd_hlen != 0)
> > */
> > if (d->bd_hlen != 0 ||
> > ((d->bd_immediate || d->bd_state == BPF_TIMED_OUT) &&
> > d->bd_slen != 0))
>
> Don't we want a POLLIN event to occur when the BPF_TIMED_OUT
> state is reached and there is still no data?
> This seems to be a timeout on waiting data, which should
> be reported up.
Something like that. I think your reply in the middle of the followup
mail gives more details. I hoped that jdp would finish fixing this
(It has something to do with a change that he made. I don't completely
understand it).
One point in the original PR seems to have been OBE (E = MFC).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208160820.g7G8K5Yo033664>