Date: Fri, 15 Jul 2016 11:34:44 -0700 From: Matthew Macy <mmacy@nextbsd.org> To: "Gleb Smirnoff" <glebius@FreeBSD.org> Cc: "Hans Petter Selasky" <hps@selasky.org>, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: callout_drain either broken or man page needs updating Message-ID: <155efd6dec6.1184b7a2546701.470842708059763905@nextbsd.org> In-Reply-To: <20160715084303.GD1076@FreeBSD.org> References: <155eca8bae0.d811ff9b567670.7363072028299444677@nextbsd.org> <087a20a1-2b8b-2050-c75f-78aac964b457@selasky.org> <155ecfa7c59.b552d7c5570767.4742594321655958557@nextbsd.org> <20160715084303.GD1076@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
---- On Fri, 15 Jul 2016 01:43:03 -0700 Gleb Smirnoff <glebius@FreeBSD.org> wrote ---- > On Thu, Jul 14, 2016 at 10:14:46PM -0700, Matthew Macy wrote: > M> > On 07/15/16 05:45, Matthew Macy wrote: > M> > > glebius last commit needs some further re-work. > M> > > M> > Glebius commit needs to be backed out, at least the API change that > M> > changes the return value when calling callout_stop() when the callout is > M> > scheduled and being serviced. Simply because there is code out there, > M> > like Mattew and others have discovered that is "refcounting" on the > M> > callout_reset() and expecting that a subsequent callout_stop() will > M> > return 1 to "unref". > M> > M> Yes. This is the cause of the "refcnt 0 on LLE at boot..." regression. I misread his comment on the reason for the failure. But, the failure is caused by a regression in callout_stop. > No it isn't. The regression is caused by unintentional change of return > value for never scheduled callout. The fix is now being tested, see PR 210884. Thanks. Let me know when I can update. -M
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?155efd6dec6.1184b7a2546701.470842708059763905>