Date: Thu, 7 Mar 2002 07:07:08 -0500 From: Mike Barcroft <mike@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307070708.F81803@espresso.q9media.com> In-Reply-To: <20020307031805.A63863@dragon.nuxi.com>; from obrien@FreeBSD.org on Thu, Mar 07, 2002 at 03:18:05AM -0800 References: <200203042027.g24KRc978637@freefall.freebsd.org> <20020307030244.B63484@dragon.nuxi.com> <20020307060920.C81803@espresso.q9media.com> <20020307031805.A63863@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@FreeBSD.org> writes: > Exactly. I would like all of these type of changes backed out until they > can be reviewed. It is too easy to not realize the author's dependence > on short-circuiting. Yes, I agree these changes should be backed out until they are reviewed. We've just witnessed a big bug in login(1) as the result of another lint/WARNS clean up. The bug in this example is most likely harmless because of the way fdopen() is written, but it is a bug none-the-less. -audit is very receptive to requests for review, and I think should be utilized to its full potential. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307070708.F81803>