Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Dec 2006 15:30:51 -0800 (PST)
From:      John Polstra <jdp@polstra.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        freebsd-arch@freebsd.org
Subject:   Re: Where do MSI quirks belong? [patch]
Message-ID:  <XFMail.20061213153051.jdp@polstra.com>
In-Reply-To: <200612121509.03785.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Dec-2006 John Baldwin wrote:

> Updated patch (relative to the stuff I just committed) is at the
> same location:
> 
> http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch
> 
> Can you review and possibly test it?

I reviewed the patch, and it looks fine except for two minor
style mismatches.  The definitions of PCI_QUIRK_DISABLE_MSI and
PCIB_DISABLE_MSI both have a tab after the #define, but in each case
the preceding line used a space after the #define.  Hang your head
in shame! ;-)

I'm updating a system to the latest -current so I can test the
patch.  I'll report back soon.

John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20061213153051.jdp>