Date: Fri, 1 Nov 2019 09:06:18 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Leandro Lupori <luporl@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354239 - head/contrib/gdb/gdb Message-ID: <f54f6537-de01-02a2-e2c2-221f8acb859f@FreeBSD.org> In-Reply-To: <201911011128.xA1BShOC057227@repo.freebsd.org> References: <201911011128.xA1BShOC057227@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/1/19 4:28 AM, Leandro Lupori wrote: > Author: luporl > Date: Fri Nov 1 11:28:43 2019 > New Revision: 354239 > URL: https://svnweb.freebsd.org/changeset/base/354239 > > Log: > [PPC64] Fix GDB sigtramp detection > > Current implementation of ppcfbsd_pc_in_sigtramp() seems to take only 32-bit > PowerPC in account, as on 64-bit PowerPC most kernel instruction addresses will > be wrongly reported as in sigtramp. > > This change adds proper sigtramp detection for PPC64. It's probably not worth fixing this in /usr/bin/gdb? At this point gdb is only installed for the kgdb in /usr/libexec on all platforms but sparc64 to serve as a fall-back for the crashinfo script in case the ports gdb isn't installed. The ports gdb should handle signal trampolines fine on ppc. It uses instruction matching patterns to detect trampolines on all supported platforms instead of static sigtramp locations. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f54f6537-de01-02a2-e2c2-221f8acb859f>